Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

atlasexec: use value receiver to keep original atlas client #74

Merged
merged 4 commits into from
Jun 17, 2024
Merged

atlasexec: use value receiver to keep original atlas client #74

merged 4 commits into from
Jun 17, 2024
+14 −0

Conversation

luantranminh
Copy link
Contributor

No description provided.

@luantranminh luantranminh marked this pull request as ready for review June 17, 2024 09:45
@luantranminh luantranminh requested review from masseelch, giautm and a team June 17, 2024 09:45
a8m
a8m reviewed Jun 17, 2024
View reviewed changes
atlasexec/atlas.go Outdated Show resolved Hide resolved
a8m
a8m reviewed Jun 17, 2024
View reviewed changes
Copy link
Member

@a8m a8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small suggestion

@luantranminh luantranminh requested a review from a8m June 17, 2024 11:16
a8m
a8m reviewed Jun 17, 2024
View reviewed changes
atlasexec/atlas.go Outdated Show resolved Hide resolved
@luantranminh luantranminh merged commit 0e0db50 into master Jun 17, 2024
3 checks passed
@luantranminh luantranminh deleted the l/value-receiver branch June 17, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a8m a8m a8m left review comments

@giautm giautm giautm approved these changes

@masseelch masseelch Awaiting requested review from masseelch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luantranminh @a8m @giautm